Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance URL Parsing Issue Fix #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BVerma-CRM
Copy link

Description

Existing parsing logic was causing issue when @server_url is something like https://ab1.my.salesforce.com
Its parsing @instance as ab1 which is incorrect
We should be getting ab1.my

@BVerma-CRM BVerma-CRM changed the title ET-3033: Instance URL Parsing Issue Fix Instance URL Parsing Issue Fix May 3, 2024
@yatish27
Copy link
Owner

Why should it be "ab1.my"

@BVerma-CRM
Copy link
Author

Why should it be "ab1.my"

@yatish27 so it should not generate instance_host as ab1.salesforce.com -- that will throw connection issue
https://share.zight.com/P8ur1PZe

We should be generating the instance_host as ab1.my.salesforce.com because its custom domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants