Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise exception when salesforce returns an exception for job #26

Merged
merged 2 commits into from
Aug 26, 2014

Conversation

jthibeaux
Copy link
Contributor

I was attempting to test things out, and struggled with some error conditions resulting in an illegal array access as opposed to a proper exception based on what came back from Salesforce. This pull request is to simply raise an exception when Salesforce returns an exception to us, rather than expecting a job ID (which is not there in some cases).

@kellydunn
Copy link
Contributor

@jthibeaux , this might help address #32 , at least clients would then be able to rescue from the Exception.

Looks like it needs a rebase, though.

@yatish27
Copy link
Owner

@kellydunn Can you test the commit, I can rebase once I get a thumbs up

@jthibeaux
Copy link
Contributor Author

Hope it helps!

@kellydunn
Copy link
Contributor

@yatish27 , I can confirm that I'm getting salesforce errors now instead of the ruby exception.

@yatish27
Copy link
Owner

Can @jthibeaux Update the PR with latest Master will merge it then

Conflicts:
	lib/salesforce_bulk_api/job.rb
@jthibeaux
Copy link
Contributor Author

Updated

@yatish27
Copy link
Owner

rebasing and updating the gem

On Mon, Aug 25, 2014 at 11:25 AM, Jeremy Thibeaux [email protected]
wrote:

Updated

Reply to this email directly or view it on GitHub
#26 (comment)
.

Yats

yatish27 pushed a commit that referenced this pull request Aug 26, 2014
raise exception when salesforce returns an exception for job
@yatish27 yatish27 merged commit e307278 into yatish27:master Aug 26, 2014
@yatish27
Copy link
Owner

yatish27 commented Sep 7, 2014

@jthibeaux Can you check if master is stable and issue is resolved. If yes i will updated the gem version and publish

@jthibeaux
Copy link
Contributor Author

I am actually not in a good position to support this change as I am not
currently using salesforce_bulk_api.

On Sat, Sep 6, 2014 at 9:17 PM, Yatish Mehta [email protected]
wrote:

@jthibeaux https://github.com/jthibeaux Can you check if master is
stable and issue is resolved. If yes i will updated the gem version and
publish


Reply to this email directly or view it on GitHub
#26 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants