This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
Improve code base #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed double quotes to single unless interpolation or special symbols are used in string - Rename methods prefixed with get (as all method essentially get something) to find - Use new Ruby (> v1.9) hash syntax - Swap out gsub with tr when there’s no regular expression for performance - Remove parenthesis for method calls with no argument
|
The reason why it fails with Travis appears to be an issue with the bundler and the configuration, rather than the code, so should be problem free. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbols are used in string
something) to find
performance