-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nuisance variables #2
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 3.58% 41.83% +38.24%
==========================================
Files 7 11 +4
Lines 251 306 +55
Branches 32 40 +8
==========================================
+ Hits 9 128 +119
+ Misses 242 176 -66
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added several inline TODO's that need to be addressed. I also set up the CI tests to fail until these TODOs addressed
…tyling, supporting multiple outcomes, adding documentation
…rsion of admg to lv dag
… certain nodes as latent
src/eliater/examples/ecoli.py
Outdated
|
||
.. code-block:: python | ||
|
||
data = pd.read_csv( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data is missing from this PR
.. code-block:: python | ||
|
||
data = pd.read_csv( | ||
"../eliater/src/eliater/data/sachs_discretized_2bin.csv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data is missing from this PR
I cleaned up the documentation in the following ways:
Remember @srtaheri @pnavada the point of all of this is to make documentation that a reader can actually follow and learn from |
I'm going to merge this now despite there being some TODO's left |
No description provided.