Add datasets #17
Closed
Add datasets #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 44.76% 46.02% +1.25%
==========================================
Files 14 15 +1
Lines 344 352 +8
Branches 42 42
==========================================
+ Hits 154 162 +8
Misses 188 188
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Merged
cthoyt
added a commit
that referenced
this pull request
Dec 14, 2023
This PR updates the analytical workflow. It now runs gets the estimand and ACE after applying each step of the workflow, then calculates the deltas against the original ACE for all steps after the initial one. It's set up to automatically run on all examples in the repo that have data, so it's important now to properly get data in (e.g. in #17) that are _fully_ documented (otherwise, these results can't be contextualized)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes everything to do with the Sachs 2005 data from #1