finished todos

y0-causal-inference · Nov 22, 2023 · 72ea417 · 72ea417
1 parent 5c20c54
commit 72ea417
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/setup.cfg b/setup.cfg
@@ -49,13 +49,14 @@ keywords =
 
 [options]
 install_requires =
-    y0>=0.2.2
+    y0>=0.2.3
     scipy
     numpy
     ananke
     pgmpy
     matplotlib
     pandas
+    seaborn
 
 # Random options
 zip_safe = false

diff --git a/src/eliater/network_validation.py b/src/eliater/network_validation.py
@@ -179,6 +179,7 @@
 import matplotlib.pyplot as plt
 import numpy as np
 import pandas as pd
+import seaborn as sns
 from numpy import mean, quantile
 from tqdm.auto import trange
 
@@ -496,7 +497,6 @@ def generate_plot_expected_p_value_vs_num_data_points(
         ]
     )
 
-    # TODO use seaborn for high quality plots
     if len(conditions) < 1:
         plt.title(f"Independence of {left} and {right}")
     else:
@@ -505,11 +505,16 @@ def generate_plot_expected_p_value_vs_num_data_points(
 
     plt.xlabel("Data Points")
     plt.ylabel("Expected p-Value")
+
+    sns.lineplot(x=list(range(start, stop, step)), y=p_vals)
+
     plt.errorbar(
         list(range(start, stop, step)),
         p_vals,
         yerr=np.array([lower_errors, higher_errors]),
         ecolor="grey",
         elinewidth=0.5,
+        fmt="none",
     )
     plt.hlines(significance_level, 0, stop, linestyles="dashed")
+    plt.show()