Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all HTML cite elements with XML entities #1377

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

guusdk
Copy link
Contributor

@guusdk guusdk commented Aug 29, 2024

Prior to this change, some XEPs are being referenced by an XML entity (eg &xep0030;) while others use a HTML cite element (eg <cite>XEP-0030</cite>). The latter doesn't seem to do anything with regards to rendering (there's no link to the reference list, for example).

All references to XEPs (and RFCs) should be based on XML entities, as (briefly) discussed in the XSF Discussion chatroom: https://logs.xmpp.org/xsf/2024-08-29#2024-08-29-67941f0944ae8365

The changes in this commit are the result of executing these two commands:

sed -i -E 's/<cite>XEP-([0-9]{4})<\/cite>/\&xep\1\;/' xep-*.xml
sed -i -E 's/<cite>RFC ([0-9]{4})<\/cite>/\&rfc\1\;/' xep-*.xml

Prior to this change, some XEPs are being referenced by an XML entity (eg `&xep0030;`) while others use a HTML cite element (eg `<cite>XEP-0030</cite>`). The latter doesn't seem to do anything with regards to rendering (there's no link to the reference list, for example).

All references to XEPs (and RFCs) _should_ be based on XML entities, as (briefly) discussed in the XSF Discussion chatroom: https://logs.xmpp.org/xsf/2024-08-29#2024-08-29-67941f0944ae8365

The changes in this commit are the result of executing these two commands:

```
sed -i -E 's/<cite>XEP-([0-9]{4})<\/cite>/\&xep\1\;/' xep-*.xml
sed -i -E 's/<cite>RFC ([0-9]{4})<\/cite>/\&rfc\1\;/' xep-*.xml
```
@guusdk guusdk force-pushed the replace-cites-with-xml-entities branch 3 times, most recently from c77a946 to 6d0d7de Compare August 29, 2024 13:58
@guusdk
Copy link
Contributor Author

guusdk commented Aug 29, 2024

This PR needs the fix for validation of multi-file PRs as provided in #1378

@iNPUTmice iNPUTmice merged commit 9c67bfc into xsf:master Sep 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants