Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoXEP: PubSub Server Information #1312

Merged
merged 10 commits into from
Jan 22, 2024
Merged

ProtoXEP: PubSub Server Information #1312

merged 10 commits into from
Jan 22, 2024

Conversation

guusdk
Copy link
Contributor

@guusdk guusdk commented Dec 19, 2023

This defines a data format and a pub-sub based way of distributing data that describes an XMPP domain and its connections to federated domains.

My direct purpose of drafting this specification is to document the data format used to populate the XMPP network graph that, at the time of writing, is hosted at https://xmppnetwork.goodbytes.im/

This defines a data format and a pub-sub based way of distributing data that describes an XMPP domain and its connections to federated domains.
Remove ambiguity with regards to having more than one connection to a remote domain. With this update, each actual (eg TCP) connection is represented by a distinct `connection` element.
Following discussion with Flow, MattJ and Jonas`, the data format was modified to:
- group connections under a remote domain
- use attributes instead of elements where appropriate
@guusdk
Copy link
Contributor Author

guusdk commented Dec 20, 2023

I have added commits that refactor the data format, per feedback from in the JDev room.

@Neustradamus
Copy link

Neustradamus commented Dec 20, 2023

@ThomasLeister: Have you seen @guusdk ProtoXEP?

EDIT 2024-01-25:

@ThomasLeister
Copy link

@Neustradamus yes, @guusdk and I have been writing yesterday on Mastodon ;-)

The XEP now mandates to include domain names of remote domains only after those remote domains advertise support for this XEP. This is intended as an opt-in mechanism.
@Neustradamus
Copy link

Instead of basing Discovery of Support on the presence of a well-known pub-sub service node, an explicit Service Discovery feature is used. This prevents a scenario in which a non-administrative user flags 'opt-in' by creating the pub-sub node.
@guusdk
Copy link
Contributor Author

guusdk commented Dec 20, 2023

I have added commits that refactor service discovery and address privacy concerns, per feedback from the JDev room.

guusdk and others added 2 commits December 22, 2023 11:13
XEP-0157 specifies the 'serverinfo' form, XEP-0128 just uses it as example.

Co-authored-by: Florian Schmaus <[email protected]>
As per Flow's suggestion, replace two data form fields that hold a pub-sub service address and node with one field, that uses a URI to identify the same pub-sub node.
@guusdk
Copy link
Contributor Author

guusdk commented Jan 17, 2024

A rendered version of this proposal can be seen at https://goodbytes.nl/tmp/xeps/pubsub-server-info.xml

@Neustradamus
Copy link

At this time, it works for:

  • Openfire
  • Prosody IM
  • Tigase XMPP Server
  • ejabberd

Thanks all devs who have added the ProtoXEP support.

@Kev
Copy link
Member

Kev commented Jan 22, 2024

@Neustradamus Please keep the comments clean from this sort of noise that's unrelated to getting the protoXEP published.

@Kev
Copy link
Member

Kev commented Jan 22, 2024

This needs to be version 0.0.1, not 1.0.0

@Kev
Copy link
Member

Kev commented Jan 22, 2024

(I've been pushing commits myself to branches to turn e.g. 1.3 into 1.0.0, but I don't want a commit making it 1.0.0 and then another reverting to 0.0.1, could you fix please Guus)

@guusdk
Copy link
Contributor Author

guusdk commented Jan 22, 2024

Done

@Kev Kev merged commit 7f854fc into xsf:master Jan 22, 2024
1 check passed
@Kev
Copy link
Member

Kev commented Jan 22, 2024

Bother, I should have checked the commit history before I merged, that's the 'change the version in its own commit' that I didn't want.

@Neustradamus
Copy link

This ProtoXEP has now a number: XEP-0485: PubSub Server Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants