Fix catalogs not returning correct/all subcatalogs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a missing prefix on the logic that would mount subcatalogs to the main application's router. This would case that subcatalogs endpoints for /datasetsm /catalogs, etc. to return in place of the root catalog.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 18 18
Lines 646 646
=======================================
Hits 557 557
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building against a catalogs with multiple subcatalogs that do not have datasets in the sub catalog's root, the /Catalogs endpoint for the root application was returning the first subcatalogs information. This made it difficult to navigate and identify datasets in the root catalog.