STAC search use assets directly #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relate issue #15 After running profiling, I found that a large amount of time was spent in the python's deepcopy. The get_assets call returns a copy which we are iterating over. By using the assets directly we can avoid the copy step and save a bunch of overhead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 18 18
Lines 646 646
=======================================
Hits 557 557
Misses 89 89 ☔ View full report in Codecov by Sentry. |
sjordan29
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
I can't think of any unintended consequences with this. It looks like this is used elsewhere in the Catalog-To-Xpublish code-base (e.g., in the _get_asset method).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate issue(s)
#15
Background
After running performance profiling, I found that a large amount of time was spent in the python's deepcopy. The get_assets call returns a copy of the asset list, which we are iterating over. By using the assets directly we can avoid the copy step and save a bunch of overhead.