Link to AWS SDK for PHP for S3 encoding vagary

xp-forge · Oct 19, 2024 · 3e230a7 · 3e230a7
1 parent 6533491
commit 3e230a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -59,6 +59,7 @@ Console::writeLine($link);
 
 Streaming uploads to S3
 -----------------------
+S3 doesn't double-encode its paths when signing them (see https://github.com/aws/aws-sdk-php/pull/633), pass `S3Key` instances to support arbitrary filenames:
 
 ```php
 use com\amazon\aws\api\SignatureV4;

diff --git a/src/main/php/com/amazon/aws/ServiceEndpoint.class.php b/src/main/php/com/amazon/aws/ServiceEndpoint.class.php
@@ -142,6 +142,7 @@ public function resource($path, array $segments= []): Resource {
    * Extracts path, encoded and params from a given target. Handles S3 keys, which do
    * not double-encode the path component in the canonical request.
    *
+   * @see    https://github.com/aws/aws-sdk-php/pull/633
    * @param  com.amazon.aws.api.SignatureV4 $signature
    * @param  string|com.amazon.aws.S3Key $target
    * @return var[]