Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cmdline #1368

Merged
merged 1 commit into from
Jul 28, 2022
Merged

add cmdline #1368

merged 1 commit into from
Jul 28, 2022

Conversation

v1nh1shungry
Copy link
Contributor

waruqi
waruqi reviewed Jul 28, 2022
View reviewed changes
packages/c/cmdline/xmake.lua Outdated
end)

on_test(function (package)
assert(package:has_cxxincludes("cmdline.h"))
Copy link
Member

@waruqi waruqi Jul 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 spaces indent

waruqi
waruqi reviewed Jul 28, 2022
View reviewed changes
packages/c/cmdline/xmake.lua Outdated
end)

on_test(function (package)
assert(package:has_cxxincludes("cmdline.h"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use has_cxxfuncs/has_cfuncs to check a interface function.

@waruqi
Copy link
Member

waruqi commented Jul 28, 2022 •
edited
Loading

C:\Users\runneradmin\AppData\Local.xmake\packages\c\cmdline\2014.2.4\4c92bae95dee4029827547582358a178\include\cmdline.h(39): fatal error C1083: Cannot open include file: 'cxxabi.h': No such file or directory

on windows.

If it does not support windows, please disable it.

on_install("linux", "macosx", "bsd", function(package)
end)

@v1nh1shungry
Copy link
Contributor Author

Yes, I notice it. I just realized that cmdline doesn't support msvc without a patch (tanakh/cmdline#6) cause I don't have msvc installed.

C:\Users\runneradmin\AppData\Local.xmake\packages\c\cmdline\2014.2.4\4c92bae95dee4029827547582358a178\include\cmdline.h(39): fatal error C1083: Cannot open include file: 'cxxabi.h': No such file or directory

on windows.

If it does not support windows, please disable it.

on_install("linux", "macosx", "bsd", function(package)
end)

Thanks! I will fix it right now.

@waruqi
Copy link
Member

waruqi commented Jul 28, 2022

you can also use add_patches to add a patch for msvc.

@v1nh1shungry
Copy link
Contributor Author

you can also use add_patches to add a patch for msvc.

Thanks for reminding. I may look into this later in another PR since I now don't use msvc and don't have it installed.

@waruqi waruqi merged commit 8638099 into xmake-io:dev Jul 28, 2022
@v1nh1shungry v1nh1shungry deleted the cmdline branch July 28, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1nh1shungry @waruqi