Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog #1809

Draft
wants to merge 125 commits into
base: develop
Choose a base branch
from
Draft

Dialog #1809

wants to merge 125 commits into from

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Mar 30, 2020 •
edited
Loading

This PR is a WIP based on Colin's original PR.

Todo:

  • styling - Smooth out default styling, ensure styling prepared for client override
  • styling - Fix up styling for all internal dialogs created by AppContainer.
  • API -- confirm default values on model and component.
  • API -- do we want to break out width and height to more closely match other apis?
  • Check that change to default context in HoistCmp makes sense.
  • Test Refresh behavior.
  • Explicit support for z-index in API?

See Manual Tests in Admin -> Tests

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@cnrudd
First cut of hoist dialog with isDraggable option.
471594f
@cnrudd
Removed unused imports.
7da244f
@cnrudd
Added canMaskClickClose prop and maskClick handler
2bab03f
@cnrudd
Fix maskclick handler
8a90e0f
@cnrudd
added todo
ec01ac3
@cnrudd
Support autoFocus: true on dialog children
73ccc65
@cnrudd
Replaced react-draggable with react-rnd, which uses react-draggable.
107c490
@cnrudd
Added --xh-dialog-box-shadow
90f5f42
@cnrudd
Support for resizing
d6650a3
@cnrudd
Fix repaint bug
9a7f05b
@cnrudd
Remove redundant use of splitLayoutProps
b3fe561
@cnrudd
Remove bug comment and fix. Bug existed only on chrome 78.3x . Upgrad…
2a65a78 
…ing to chrome v79 fixed the issue.
@cnrudd
Refactored with elementfactory.
c8f401b
@cnrudd
Remove need for constructor.
8e347e3
@cnrudd
Converted Dialog from class comp to function comp.
3af10ed
@cnrudd
Support resizable config
a3b640b
@cnrudd
Refactor, with dialogHeader impl
d583d76
@cnrudd
Linting.
fad1660
@cnrudd
Let dialogs autocenter based on content dimensions;
88b0d45 
+ Fix css for for handle cursor
+ Cannot create a default  model since a model is needed to show() dialog.
@cnrudd
Use given width and height props if resizeable
c06514e
@cnrudd
throw if no dims props with resizable = true
42a4d00
@cnrudd
Add Maximize Minimize toggle if resizable.
d7d7a10
@cnrudd
Implemented localstorage statemodel on dialog.
41c129c
@cnrudd
Improve handling of 0 position values.
cfaa2af
@cnrudd
Improve safe state loading on dialog.
e3169c1
@cnrudd
Remove unnecessary setting of defaults on RnD, fix unMaximize.
1d57410
@cnrudd
Support x, y props.
21f9f5d
@cnrudd
Merge branch 'develop' into hoistDialog
10f08c2
@cnrudd
Merge branch 'develop' into hoistDialog
40c27b5
@cnrudd
Cleanup setState on render logic
28c1175
@lbwexler lbwexler added the wip label Mar 30, 2020
@lbwexler lbwexler linked an issue Mar 30, 2020 that may be closed by this pull request
Window / Dialog component - replaces direct use of Blueprint dialog #861
Open
lbwexler and others added 20 commits March 30, 2020 17:35
@lbwexler
Update yarn.lock
67ceec2
@lbwexler
Merge branch 'develop' into dialogX
141da17 
# Conflicts:
#	yarn.lock
@lbwexler
Merge branch 'develop' into dialogX
c78f349 
# Conflicts:
#	yarn.lock
@lbwexler
Merge branch 'develop' into dialogX
d7f0b21
@lbwexler
+ Incorporate parent resizing behavior
0e9241e 
+ re-organize parameters
@lbwexler
Don't set position on user induced re-size
3afec6a
@lbwexler
Doc fix
3c7c855
@lbwexler
Merge branch 'develop' into dialogX
536f57f
@lbwexler
Cleanup checkpoint
8d63efb
@lbwexler
Continued Refactor
7005f6d
@lbwexler
Support Percentage Width and Height
c9bd74b
@lbwexler
Checkpoint
f55683f
@lbwexler
Merge branch 'develop' into dialogX
dbedd17 
# Conflicts:
#	desktop/appcontainer/AboutDialog.js
#	desktop/appcontainer/ExceptionDialog.js
#	desktop/appcontainer/ExceptionDialogDetails.js
#	desktop/appcontainer/FeedbackDialog.js
#	desktop/appcontainer/OptionsDialog.js
@lbwexler
Update to new package import
206bc7c
@lbwexler
Provide proper renderMode/refreshMode support
0c82994
@cnrudd
Merge branch 'develop' into dialogX
4710630
@cnrudd
Latest yarn.lock
b29e92b
@lbwexler
Merge branch 'develop' into dialogX
0200375 
# Conflicts:
#	admin/tabs/activity/clienterrors/ClientErrorModel.js
#	package.json
#	yarn.lock
@lbwexler
Merge branch 'dialogX' of https://github.com/xh/hoist-react into dialogX
0868e64 
� Conflicts:
�	yarn.lock
@cnrudd
Merge branch 'develop' into dialogX
a654ae0
@amcclain amcclain mentioned this pull request Jun 26, 2020
Closed
@amcclain amcclain marked this pull request as draft October 16, 2020 20:34
@amcclain amcclain removed the wip label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window / Dialog component - replaces direct use of Blueprint dialog
3 participants
@lbwexler @amcclain @cnrudd