Adding a safeguard for UEFI/legacy config switch #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function searches for the /boot/efi mount point in the /etc/fstab file of the mount point directory passed as parameter and returns True if present, False otherwise. This will allow to check that an existing installation or backup boot mode matches with the installer boot mode. Signed-off-by: Thierry Escande <[email protected]>
This patch checks the boot mode of an existing backups and disallows its restoration if it differs from the installer one. This uses the new helper function is_rootf_uefi(). Signed-off-by: Thierry Escande <[email protected]>
This patch checks that the current installation is not proposed as upgradeable if its boot mode differs from the installer one. This uses the helper function is_rootfs_uefi(). Signed-off-by: Thierry Escande <[email protected]>
|
Why block changing the boot mode while upgrading? In principle, there should be no issue with it since the bootloader is reinstalled. |
|
This is what the installer already does in partitionTargetDisk() but a few steps later. So the goal is to not propose an existing installation for upgrade if boot modes mismatch since this will fail anyway with an error message, which is confusing for users when the upgrade seems to have started. |
Isn't there some partitioning differences with that, with BIOS installs lacking a |
tescande
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #11, this series adds checks on the current installation and existing backups to not proposed them for upgrade and/or restore if their boot mode (UEFI/legacy) differs from the installer one. To achieve this, a helper function
is_rootf_uefi()is added.