-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the dependencies of old loader #421
Conversation
Signed-off-by: subaoon <[email protected]>
Signed-off-by: subaoon <[email protected]>
Signed-off-by: subaoon <[email protected]>
@tohojo, @netoptimizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing things up; just one comment :)
$ t exec -n test -- ./xdp_loader -d veth0 -F --progsec xdp_pass | ||
$ t load -n test -- -F --progsec xdp_icmp_echo | ||
$ t exec -n test -- ./xdp-loader load --prog-name xdp_pass_func veth0 xdp_prog_kern.o | ||
$ t load -n test -- --prog-name xdp_icmp_echo_func xdp_prog_kern.o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three invocations of xdp_loader
at the end of the README file as well. Let's include those while you're fixing things up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback.
updated README.
Signed-off-by: subaoon <[email protected]>
Commit 0ded568, made by @donaldh and already merged, changed COPY_LOADER from
xdp_loader
toxdp-loader
, but there are still dependencies onxdp_loader
.I fixed the following:
xdp-loader
instead ofxdp_loader
in testenv.sh.xdp-loader
and must be pinned.related issues
#393