Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to python3 #14

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Switch to python3 #14

wants to merge 16 commits into from

Conversation

ydirson
Copy link
Contributor

@ydirson ydirson commented Feb 21, 2024

Patches ordered, starting with py2-compatible changes

gthvn1
gthvn1 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@gthvn1 gthvn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ydirson ydirson marked this pull request as draft February 26, 2024 09:41
@ydirson
Copy link
Contributor Author

ydirson commented Feb 28, 2024

There are big problematic things that would require rewriting, like coalesce.py pickling whole Popen objects, which happened to work in python2 but not any more in 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthvn1 gthvn1 gthvn1 approved these changes

@Wescoeur Wescoeur Wescoeur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydirson @gthvn1 @Wescoeur