Add check_installed function in updater.py #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
approved these changes
Feb 9, 2024
Wescoeur
force-pushed
the
add-is_installed-method
branch
from
381e04b
to
1343259
Compare
Signed-off-by: Ronan Abhamon <[email protected]>
Wescoeur
force-pushed
the
add-is_installed-method
branch
from
1343259
to
27eff82
Compare
Wescoeur
changed the title
stormi
reviewed
Feb 12, 2024
Comment on lines
+191
to
+192
| packages = re.sub(r'\s+', ' ', packages).replace(',', ' ').split(' ') | ||
| packages = filter(lambda package: package, packages) |
There was a problem hiding this comment.
What input is supported (spaces, commas...) should be specified in the readme and tested in the unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on XCP-ng 8.2 & 8.3.
Documentation updated.