Test HTTP Strict Transport Security header #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the HSTS header is not added by XAPI server. This test checks that it is the case and it also tests that once the HSTS is enabled it is added by the server. It is enabled by setting add_hsts_response_header to true in XAPI conf. Signed-off-by: Guillaume <[email protected]>
|
We still need to backport the HSTS that has been merged upstream xen-api PR 5069 to be able to run this test. Or wait an update of our xapi to a more recent xen-api. |
|
@benjamreis & @stormi I added you as reviewers because I closed the previous PR #152 by deleting branch on my repo. But there is nothing new. Sorry for the spam... |
benjamreis
approved these changes
Sep 12, 2023
|
XAPI was updated to |
|
Merging was a mistake: the test was never adapted after the merge of the upstream PR, 3 months ago. The configuration key the fixture needs to define is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the HSTS header is not added by XAPI server. This test checks that it is the case and it also tests that once the HSTS is enabled it is added by the server. It is enabled by setting add_hsts_response_header to true in XAPI conf.