Change test fsp for another repo and better teardown

[gduperrey]

We changed the test for fsp to use repo on repo.vates.tech and to have a better teardown when the test failed. We con't want that the repo file stayed on the test server.

[ydirson]

Also, commit says "We con't"

[ydirson]

if we're going to name then, we likely want to avoid that eg. a typo selects the fallback. Suggestion:

base_repo_url = {
  'xcp-ng': 'http://mirrors.xcp-ng.org/',
  'vates': 'https://repo.vates.tech/xcp-ng/',
}[base_repo]

repo_id would also be more descriptive than base_repo

[stormi]

There's an assert, so no typo will select the fallback. We can rework the code if/when we add a third component.

[stormi]

Regarding repo_id, this evokes an identifier for a specific yum repository, to me, so I don't find it more descriptive than base_repo.

[ydirson]

There's an assert, so no typo will select the fallback. We can rework the code if/when we add a third component.

The idiom with assert makes it so that things have to be changed in 2 places; the dict idiom only one single place.
And I think it's much more visual.

Regarding repo_id

repo_nickname would be more on the point?

[stormi]

repo_nickname would be more on the point?

It's really a "base" something. The thing is repo may have several meanings. Either a location on a mirror for a whole distro, or a specific yum repository such as https://updates.xcp-ng.org/8/8.3/lab/x86_64/

There must be a better name than base_repo, but here it's just good enough and the other suggestions don't look better to me. Let's keep base_repo.

[stormi]

There's an assert, so no typo will select the fallback. We can rework the code if/when we add a third component.

The idiom with assert makes it so that things have to be changed in 2 places; the dict idiom only one single place. And I think it's much more visual.

This is true, but if we change it now, we already consume one change so you're back to two. And it's definitely not like we're going to have trouble changing it the way it is now if we need to.