Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair LINSTOR tests to support latest driver version #150

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Wescoeur
Copy link
Member

@Wescoeur Wescoeur commented Jun 5, 2023

No description provided.

@Wescoeur Wescoeur force-pushed the ran-fix-linstor-tests branch 4 times, most recently from 50e1563 to b63b640 Compare June 6, 2023 08:38
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobs.py needs to be updated so that the excluded linstor tests now run

lib/host.py Outdated Show resolved Hide resolved
@Wescoeur Wescoeur force-pushed the ran-fix-linstor-tests branch 2 times, most recently from ed14953 to 34d1537 Compare June 6, 2023 13:10
@Wescoeur Wescoeur requested a review from stormi June 6, 2023 13:16
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Before merging, we'll check it runs well on the CI hosts (physical and virtual).

@gduperrey please test on 8.2 CI hosts. A full run on Q2/Q3, and a full run on the 3-host virtual pool too.

@gduperrey
Copy link
Contributor

I don't understand what you're asking. A full run use both physicals or virtuals hosts. It depends the tests running.
Maybe we could discuss this on mattermost so i can understand what you have in mind.

@stormi
Copy link
Member

stormi commented Jun 13, 2023

I mean full run of linstor tests only.

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also not forget that linstor must be "repaired" on 8.3 before we can merge this PR. Or, make them skipped on 8.3 for now.

@Wescoeur Wescoeur merged commit 6ab0e43 into master Jul 21, 2023
4 checks passed
@Wescoeur Wescoeur deleted the ran-fix-linstor-tests branch July 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants