Aggregate all dims simultaneously in conservative #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevang
commented
Sep 25, 2024
dcherian
reviewed
Sep 25, 2024
BSchilperoort
requested changes
Sep 26, 2024
There was a problem hiding this comment.
I added a benchmarking notebook following from the example in #42 and I think the results look quite good now.
The benchmark looks good! It even is quite generous to xesmf, as the ESMF weight generation is left out of the comparison 😉
Can you add the benchmark to the docs index though (index.rst), so it will show up there?
BSchilperoort
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at weatherbench's conservative regridding implementation here and realized we could also einsum over all dimensions simultaneously. This simplifies the code and also makes the NaN tracking implementation way more efficient.
I added a benchmarking notebook following from the example in #42 and I think the results look quite good now.