Merge pull request #56 from robertbreker/pep8

Enable automated PEP-8 checking

.travis.yml

@@ -1,5 +1,13 @@
 language: c
-install: wget https://raw.githubusercontent.com/ocaml/ocaml-travisci-skeleton/master/.travis-opam.sh
-script: bash -ex .travis-opam.sh
+# Avoid running in a container, as this doesn't work for the ocaml tests.
+sudo: required
+python:
+  - "2.7"
+install:
+  - wget https://raw.githubusercontent.com/ocaml/ocaml-travisci-skeleton/master/.travis-opam.sh
+  - pip install --user flake8
+script:
+  - bash -ex .travis-opam.sh
+  - flake8 --show-source --show-pep8 python
 env:
   - OCAML_VERSION=4.02 PACKAGE=xapi-storage

python/example/datapath/Datapath.activate

@@ -1,9 +1,12 @@
 #!/usr/bin/env python
 
 import sys
-import xapi, d
+import xapi
+import d
+
 
 class Implementation(d.Datapath_skeleton):
+
     def activate(self, dbg, uri, domain):
         return
 

python/example/datapath/Datapath.attach

@@ -1,14 +1,18 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, d
+import sys
+import urlparse
+import xapi
+import d
+
 
 class Implementation(d.Datapath_skeleton):
+
     def attach(self, dbg, uri, domain):
         u = urlparse.urlparse(uri)
         return {
             'domain_uuid': '0',
-            'implementation': [ 'Qdisk', u.path ],
+            'implementation': ['Qdisk', u.path],
         }
 
 if __name__ == "__main__":

python/example/datapath/Datapath.deactivate

@@ -1,9 +1,12 @@
 #!/usr/bin/env python
 
 import sys
-import xapi, d
+import xapi
+import d
+
 
 class Implementation(d.Datapath_skeleton):
+
     def deactivate(self, dbg, uri, domain):
         return
 

python/example/datapath/Datapath.detach

@@ -1,9 +1,12 @@
 #!/usr/bin/env python
 
 import sys
-import xapi, d
+import xapi
+import d
+
 
 class Implementation(d.Datapath_skeleton):
+
     def detach(self, dbg, uri, domain):
         return
 

python/example/volume/Plugin.Query

@@ -1,9 +1,12 @@
 #!/usr/bin/env python
 
 import sys
-import xapi, p
+import xapi
+import p
+
 
 class Implementation(p.Plugin_skeleton):
+
     def query(self, dbg):
         return {
             "plugin": "ffs",

python/example/volume/Plugin.diagnostics

@@ -1,9 +1,12 @@
 #!/usr/bin/env python
 
 import sys
-import xapi, p
+import xapi
+import p
+
 
 class Implementation(p.Plugin_skeleton):
+
     def diagnostics(self, dbg):
         return "This should return useful debug output, to help support understand the problem."
 

python/example/volume/SR.attach

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.SR_skeleton):
+
     def attach(self, dbg, uri):
         u = urlparse.urlparse(uri)
         return "A local ID for the SR"

python/example/volume/SR.create

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.SR_skeleton):
+
     def create(self, dbg, uri, configuration):
         u = urlparse.urlparse(uri)
         print repr(configuration)

python/example/volume/SR.destroy

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.SR_skeleton):
+
     def destroy(self, dbg, sr):
         return
 

python/example/volume/SR.detach

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.SR_skeleton):
+
     def detach(self, dbg, sr):
         return
 

python/example/volume/SR.ls

@@ -1,19 +1,23 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.SR_skeleton):
+
     def ls(self, dbg, sr):
         u = urlparse.urlparse(sr)
-        return [ {
+        return [{
             "key": "unknown-volume",
             "name": "unknown-volume",
             "description": "",
             "read_write": True,
             "virtual_size": 1,
             "uri": ["file:\/\/\/secondary\/sr\/unknown-volume"]
-        } ]
+        }]
 
 if __name__ == "__main__":
     cmd = v.SR_commandline(Implementation())

python/example/volume/Volume.clone

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def clone(self, dbg, sr, key):
         u = urlparse.urlparse(sr)
         return {

python/example/volume/Volume.create

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def create(self, dbg, sr, name, description, size):
         u = urlparse.urlparse(sr)
         return {

python/example/volume/Volume.destroy

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def destroy(self, dbg, sr, key):
         return
 

python/example/volume/Volume.resize

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def resize(self, dbg, sr, key, new_size):
         u = urlparse.urlparse(sr)
         return

python/example/volume/Volume.snapshot

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def snapshot(self, dbg, sr, key):
         u = urlparse.urlparse(sr)
         return {

python/example/volume/Volume.stat

@@ -1,9 +1,13 @@
 #!/usr/bin/env python
 
-import sys, urlparse
-import xapi, v
+import sys
+import urlparse
+import xapi
+import v
+
 
 class Implementation(v.Volume_skeleton):
+
     def stat(self, dbg, sr, key):
         u = urlparse.urlparse(sr)
         return {

python/setup.py

@@ -1,9 +1,9 @@
 from distutils.core import setup
-setup (name = "xapi-storage",
+setup(name="xapi-storage",
       version='0.1',
       description='Xapi storage interface',
       author='David Scott',
       author_email='[email protected]',
       url='https://github.com/xapi-project/xapi-storage/',
       packages=['xapi', 'xapi.storage', 'xapi.storage.api'],
-)
+      )