Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rgen] Implement SmartEnums code emittion. #21465

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

[Rgen] Implement SmartEnums code emittion. #21465

wants to merge 26 commits into from
+3,847 −220

Conversation

mandel-macaque
Copy link
Member

@mandel-macaque mandel-macaque commented Oct 17, 2024 •
edited
Loading

This change brings the following:

  1. We now generate the Extension classes for the SmartEnums.
  2. Bumped the roslyn version, the one we were using had a bug when using
    dir separators in the name hint for a generated file.
  3. Generated code is added under the expected directory for bgen to
    allow the API diff.

PS: Create as a draft because it depends on a previous PR but I want to see that the generated diff is correct.

mandel-macaque and others added 9 commits October 16, 2024 13:21
@mandel-macaque
[Rgen] Provide all the wiring to allow to emit code.
e5b75d2 
Add the following:

1. Code needed to register the changes in the compiler pipeline.
2. Code that will add the using statements for the generated code that
   match those in the binding file.
3. Code that allows to write tabbed code in a way we do not have to keep
   track of indentation.

We have the first unit test that verifies code generation by checking
the using statements.
Auto-format source code
1ac8974
@mandel-macaque
Fix makefile.
89aef62
@mandel-macaque
Merge branch 'main' into dev/mandel/rgen-wiring
f6f8811
@mandel-macaque
Merge TryValidate and Emit since it makes the API cleaner.
c8ddb0a
@mandel-macaque
enuable nullable first so that emitters can add extra namespaces.
56c7ed2
@mandel-macaque
Fix the sample projects.
ae1b14a
@mandel-macaque
Fix analyzer tests.
d4fb40e
Auto-format source code
ad83462
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@mandel-macaque mandel-macaque mentioned this pull request Oct 17, 2024
Open
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 2 tests failed, 99 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d836caf2a7e41e0ca9d2fd979d02cff06f091a71 [PR build]

@mandel-macaque mandel-macaque force-pushed the dev/mandel/rgen-smart-enums branch 2 times, most recently from 2284712 to afb8217 Compare October 18, 2024 17:54
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@mandel-macaque mandel-macaque force-pushed the dev/mandel/rgen-smart-enums branch 2 times, most recently from 4a0295c to 5acc05a Compare October 18, 2024 18:02
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@mandel-macaque
[Rgen] Implement SmartEnums code emittion.
f91473f 
This change brings the following:

1. We now generate the Extension classes for the SmartEnums.
2. Bumped the roslyn version, the one we were using had a bug when using
   dir separators in the name hint for a generated file.
3. Generated code is added under the expected directory for bgen to
   allow the API diff.
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: f11bb1b036b8b248da527c94390abe34c00254c5 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne will be requested when the pull request is marked ready for review rolfbjarne is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandel-macaque @vs-mobiletools-engineering-service2