Fix described in #21132 #21137
Closed
Fix described in #21132 #21137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #21140 (which is a copy of this one), because our CI will only build pull requests from the origin repository. |
rolfbjarne
added a commit
that referenced
this pull request
Aug 29, 2024
Before PR: NSUrlSessionHandler.Proxy property throws NSE when client code set any value (including `null`):  After PR NSUrlSessionHandler.Proxy property throws NSE only when the client code tries to set a value different from `null` (Custom proxy is not supported right now in iOS implementation so setting a value other than null must throws NSE):  Fixes #21132. PR originally submitted by @adospace in #21137. Co-authored-by: adospace <[email protected]>
rolfbjarne
pushed a commit
that referenced
this pull request
Sep 2, 2024
…ndler.Proxy to null (#21147) Before PR: NSUrlSessionHandler.Proxy property throws NSE when client code set any value (including `null`):  After PR NSUrlSessionHandler.Proxy property throws NSE only when the client code tries to set a value different from `null` (Custom proxy is not supported right now in iOS implementation so setting a value other than null must throws NSE):  Fixes #21132. PR originally submitted by @adospace in #21137. Co-authored-by: adospace <[email protected]> Backport of #21140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before PR
NSUrlSessionHandler.Proxy property throws NSE when client code set any value (including
null)After PR
NSUrlSessionHandler.Proxy property throws NSE only when the client code tries to set a value different from
null(Custom proxy is not supported right now in iOS implementation so setting a value other than null must throws NSE)The reason behind the change is described in #21132