Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sequencer error code VALIDATE_FAILURE #558

Merged
merged 1 commit into from
May 20, 2024

Conversation

jbcaron
Copy link
Contributor

@jbcaron jbcaron commented Feb 28, 2024

This PR add the error code StarknetErrorCode.VALIDATE_FAILURE from sequencer API.

@xJonathanLEI
Copy link
Owner

Thanks for the PR. However, starknet-core/src/types/codegen.rs is for RPC types, which is strictly derived from the specification and must not be manually edited.

The RPC error type already contains a ValidationFailure variant, which you can use when converting from sequencer error to RPC error.

@xJonathanLEI xJonathanLEI changed the title Add Error Handling for Invalid Transaction Validation feat: sequencer error code VALIDATE_FAILURE May 20, 2024
@xJonathanLEI xJonathanLEI merged commit d5359a0 into xJonathanLEI:master May 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants