Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Improve the performance of temporal group averaging #689

Merged
merged 8 commits into from
Sep 4, 2024
Merged

[Refactor] Improve the performance of temporal group averaging #689

merged 8 commits into from
Sep 4, 2024

Commits on Aug 30, 2024

  1. Add initial temporal performance refactor code

    @tomvothecoder
    tomvothecoder committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0d56ed5 View commit details
    Browse the repository at this point in the history

  2. Extract _calculate_departures() method

    @tomvothecoder
    tomvothecoder committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4c3845d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Remove unnecessary validation of weights in _get_weights() 

    Replace `.load()` with `.astype("timedelta64[ns"])` for clarity
    @tomvothecoder
    tomvothecoder committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    22312a5 View commit details
    Browse the repository at this point in the history

  2. Update xcdat/temporal.py

    @tomvothecoder
    tomvothecoder authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0f4a1af View commit details
    Browse the repository at this point in the history

  3. Fix _keep_weights() for departures and average modes

    @tomvothecoder
    tomvothecoder committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b97e8ae View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Update xcdat/temporal.py

    @tomvothecoder
    tomvothecoder authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    84a7e10 View commit details
    Browse the repository at this point in the history

  2. Update _get_weights() tests 

    - Check if sum of each weight group equals 1.0
- Update `_get_weights()` docs to remove validation portion
    @tomvothecoder
    tomvothecoder committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e77631e View commit details
    Browse the repository at this point in the history

  3. Update xcdat/temporal.py

    @tomvothecoder
    tomvothecoder authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6459c1b View commit details
    Browse the repository at this point in the history