Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom seasons spanning calendar years #423

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add support for custom seasons spanning calendar years #423

wants to merge 11 commits into from

Commits on Oct 3, 2024

  1. Add baseline unit tests 

    - Remove logic for requiring all 12 months to be used
    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    70b3864 View commit details
    Browse the repository at this point in the history

  2. Add support for shifting months in seasons spanning calendar year

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    74bc11d View commit details
    Browse the repository at this point in the history

  3. Add explaination of code for spanning months

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    eec0156 View commit details
    Browse the repository at this point in the history

  4. Replace drop_incomplete_djf with drop_incomplete_seasons

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    1 Configuration menu
    Copy the full SHA
    bae2bc9 View commit details
    Browse the repository at this point in the history

  5. Fix _drop_incomplete_seasons() adding dims to variables 

    - Add conditional that determines whether subsetting time coordinates is necessary with custom seasons
- Update docstrings for `season_config`
- Add tests
    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    661b0db View commit details
    Browse the repository at this point in the history

  6. Add deprecation warning for "drop_incomplete_djf"

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5003db9 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a12cf30 View commit details
    Browse the repository at this point in the history

  8. Add test to cover missing line in _drop_incomplete_season

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    caebb64 View commit details
    Browse the repository at this point in the history

  9. Add clear error message when no complete seasons are found

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1293c01 View commit details
    Browse the repository at this point in the history

  10. Update deprecation version for drop_incomplete_djf

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c5c4d46 View commit details
    Browse the repository at this point in the history

  11. Update static time dim ref to CF interpreted dim key

    @tomvothecoder
    tomvothecoder committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1a91228 View commit details
    Browse the repository at this point in the history