Fixed Null Reference exception, conversion hangs and merged with the main branch #322
+180
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final 5.1 fixes from develop
…hout valid Contexts supplied. Should address xBimTeam/XbimWindowsUI#94
…hese are in violation of the specs but we should support them better. E.g. 2x3_Arboleda_Bldg-Arch.ifc
Ignore an unimplemented test in this branch
…ndling of closed shells and swept curved surfaces
No significant changes
Removed script to tag sources. This is now done in the Devops trigger, on build success
…face. This is to fix runtime issues when using latest Geometry and Essentials from Myget Master See xBimTeam#285 (comment)
This is just a stop gap to fix the master build. Need to revert this when merging develop,
GeorgDangl
suggested changes
Mar 29, 2021
GeorgDangl
approved these changes
Mar 29, 2021
dmk-rib
changed the title
|
Have you a chance to take a look at this commit? |
|
Yeah, I'm also interested to see this in master. I have a couple of files that halts without this fix. |
|
Is anyone still maintaining this repo or is there a specific reason this is not merged into master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has fixed Null Reference bugs, fixed conversion hangs and other improvements from the main branch