Add transport parameters transport.vfs.MinimumAge and transport.vfs.MaximumAge #2089
Conversation
|
|
…card_master Add the fix in synapse PR 1484 again which is reverted by PR 1719
| @@ -515,6 +531,7 @@ public boolean loadConfiguration(ParameterInclude params) throws AxisFault { | |||
| } | |||
|
|
|||
| protected boolean loadConfigurationsFromService(ParameterInclude params) throws AxisFault { | |||
| System.out.println("loading config from service"); | |||
There was a problem hiding this comment.
Shall we change this to use the logger? Using System.out.println to print logs is not encouraged.
There was a problem hiding this comment.
This lines was added for debugging purpose, we just removed it
|
Thank you for your contribution. Can you address comments in order to merge the PR? |
ljuillerat
force-pushed
the
feature/WSO2-213
branch
2 times, most recently
from
1b75f55
to
4828ec5
Compare
…aximumAge which check file age (seconds)
ljuillerat
force-pushed
the
feature/WSO2-213
branch
from
4828ec5
to
1872426
Compare
|
Building CI seems failing but for external reasons. Would it be possible to have a look ? |
|
@arunans23 Based on our PR, it doesn't seem that the failing build is concerned. Would it be possible to confirm ? |
| return maximumAge; | ||
| } | ||
|
|
||
| public boolean hasAgeCheck(){ |
There was a problem hiding this comment.
Are we utilizing this method? If not, shall we remove this?
There was a problem hiding this comment.
Method is effectively unused. Just removed it from this PR.
Yes. It is not related to this PR. I have added a small comment. Shall we address it before merging the PR? |
Remove unreferenced method
|
Thank you for addressing the comments on time. We can track the doc changes from a previous issue related to VFS. |
###Goal
This adds the transport parameters transport.vfs.MinimumAge and transport.vfs.MaximumAge which check for file age since last mod in seconds.
###Sample
<parameter name="transport.vfs.MinimumAge">10</parameter> <parameter name="transport.vfs.MaximumAge">60</parameter>reads files that are atleast 10 seconds old but no older than a minute.