Fix metric_keys
as a top-level query parameter
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
metric_keys
inbrandscape_data
method is not a top levelMotivation and Context
The
metric_keys
parameter inbrandscape_data
was not correctly allocated to the top level of the query, and parsed instead as a filter.This PR adds
metric_keys
as a parameter of theQuery
object, to make it work with the Fount API.Tests have been updated to check whether parameters are being parsed and allocated correctly by the
Client
endpoint methods.How Has This Been Tested?
Ran
nox
tests as well asmypy
andpylint
.Checklist