Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric_keys as a top-level query parameter #6

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

nachomaiz
Copy link
Contributor

Description

metric_keys in brandscape_data method is not a top level

Motivation and Context

The metric_keys parameter in brandscape_data was not correctly allocated to the top level of the query, and parsed instead as a filter.

This PR adds metric_keys as a parameter of the Query object, to make it work with the Fount API.

Tests have been updated to check whether parameters are being parsed and allocated correctly by the Client endpoint methods.

How Has This Been Tested?

Ran nox tests as well as mypy and pylint.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nachomaiz nachomaiz merged commit edcf387 into main Jul 19, 2023
10 checks passed
@nachomaiz nachomaiz deleted the fix-metric-keys branch July 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant