Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group_id #17

Merged
merged 22 commits into from
Oct 17, 2023
Merged

Fix group_id #17

merged 22 commits into from
Oct 17, 2023

Conversation

nachomaiz
Copy link
Contributor

Description

Fix

  • ⚠️ (Breaking) Fix metric_id param to correct group_id name in bavapi.brand_metric_groups top level function.

Internal

  • 🔒 Renamed reference module as private. This will remove it from the code reference docs.
  • ♻️ Set new dependency minimum versions for compatibility.

Docs

  • 🎉 Code reference section now directs to the sync documentation by default.
  • 📓 More documentation for the sync and client modules.
  • 📓 Added more clarity around expected environment variables when storing API keys. bavapi will always look for an API key in the BAV_API_KEY environment variable.
  • ⚙️ Refactored code reference generation to support renaming of reference module.

Motivation and Context

Cleanup of public interface and documentation in preparation for full release.

bavapi is now in beta stage.

How Has This Been Tested?

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nachomaiz nachomaiz merged commit 1945b43 into main Oct 17, 2023
11 checks passed
@nachomaiz nachomaiz deleted the fix-group-id branch October 17, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant