Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NAN checking when converting String to Number #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ansromanov
Copy link

@ansromanov ansromanov commented Feb 17, 2018

There is no checking for NaN where converting strings to numbers:
node learnyounode.js test this output 7 7fdf 14 65 will return NaN as result.

}

console.log(result)
console.log(result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End-of-Line missing, otherwise looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants