Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe permissions and add dialog #985

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Remove unsafe permissions and add dialog #985

merged 5 commits into from
Oct 3, 2024

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Sep 26, 2024

Fixes #915

image

andyholmes
andyholmes approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight-forward, LGTM!

EDIT: except the lint job I guess 😅

@sonnyp sonnyp mentioned this pull request Sep 26, 2024
Merged
@bragefuglseth
Copy link
Contributor

I'd:

  • use .card styling for the command box
  • use a boxed list for the permission explanations
  • change the permission explanation section title to "What it Does" for the sake of simplicity

Otherwise this LGTM as well!

@sonnyp sonnyp merged commit e5c077b into main Oct 3, 2024
1 check failed
@sonnyp sonnyp deleted the permissions branch October 3, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyholmes andyholmes andyholmes approved these changes

@bragefuglseth bragefuglseth Awaiting requested review from bragefuglseth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inform users when a permission is required for a demo
3 participants
@sonnyp @bragefuglseth @andyholmes