Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Remove usage of Adw.PreferencesRow #955

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

BharatAtbrat
Copy link
Contributor

@BharatAtbrat BharatAtbrat commented Jul 2, 2024

  • Initial implementation to move away from Adw.PreferencesRow
  • Minor style changes to match the previous design
  • Changed signal name to lang_activated since it clashed with a preexisting activated signal in Adw.ActionRow

Let me know if there are any issues with the code/ any improvements :)
Screegrabs of the change:

2024-07-03.00-21-54.mp4

Initial implementation to move away from Adw.PreferencesRow and
shift to Adw.ActionRow
Minor style changes to match the previous design
@BharatAtbrat BharatAtbrat requested a review from sonnyp as a code owner July 2, 2024 18:57
@BharatAtbrat BharatAtbrat changed the title Library: Remove usage of Adw.PreferencesRow library: Remove usage of Adw.PreferencesRow Jul 2, 2024
@sonnyp sonnyp merged commit 78dbbfb into main Jul 3, 2024
1 check failed
@sonnyp sonnyp deleted the atbrat/removeprefrow branch July 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants