Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support analysis / types with Rust Analyzer #883

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Feb 14, 2024

Fixes #881
It still takes a bit until diagnostics arrive, but this way error messages from cargo are included as well.

Also moves the target dir to a common place, similar to how we do it when we compile Rust.

Fixes #881
It still takes a bit until diagnostics arrive, but this way error messages from `cargo` are included as well.
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still only getting syntax diagnostics.

Anything specific I need to do?

image

image

@Hofer-Julian
Copy link
Contributor Author

I'm still only getting syntax diagnostics.

Anything specific I need to do?

image

image

I shouldn't be necessary to do anything special, but I also noticed that it doesn't always work on my machine.

Before merging, we should also look out if this PR introduces regressions. If yes, maybe we just merge a subset of it.

theCapypara and others added 26 commits March 24, 2024 17:24
Before this change, Workbench installed via Flatpak was not able to run
Vala demos that required Shumate, Libportal or Libspelling because their
header files were removed by the cleanup process. The versions of
Workbench that are run from Builder or flatpak-vscode can actually
compile and execute this demos because they don't do any clean-up, and
therefore none of the header files are deleted, which is probably why
this issue went unnoticed for quite some time even when porting the
affected demos to Vala.

In order to test this changes and compare them with the current version
of Workbench, it is necessary to export a bundle and install it, so the
cleanup process is actually done.

Closes #885
`libxmljs` one of our nodejs dependencies requires a C++ compiler
Co-authored-by: Sonny Piers <[email protected]>
Co-authored-by: Marco Capypara Köpcke <[email protected]>
This commit adds my name to the contributor list for #857 

Thanks so much for the patience and help I received from you @sonnyp
@theCapypara
We only support English
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support analysis / types in Rust LSP
7 participants