An/feature/615 profile #616

RightHennessy · 2023-11-21T08:02:01Z

😋 작업한 내용

종료된 스터디 목록 버그 픽스
uimodel 제거
data binding -> view binding
flow 적용
uiState 적용

🙏 PR Point

flow를 적용하는게 의미가 있는지를 모르겠네요.. 훈수 좀 둬주세요

👍 관련 이슈

Resolved : [프로필 뷰] 리팩터링 작업 #615

현재 release에서 프로필 뷰가 정상작동하지 않는답니다.. (허허)
다음 업데이트 때 추가해야합니다...

- FinishedStudyUiModel - UserProfileUiModel

github-actions · 2023-11-21T08:05:10Z

Test Results

9 tests 9 ✔️ 0s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 543ebf0.

s9hn

데공사(데이터바인딩 제거 대공사) 고생하셨습니다.
사실 Hotflow는 라이브데이터와 크게 다를점이 없죠
테스트를 별도로 진행하지 않는다면, 지금은 크게 이점을 느낄곳이 없다고 생각함미다

s9hn · 2023-11-21T08:41:01Z

android/app/src/main/java/com/created/team201/data/mapper/UserProfileMapper.kt

@@ -24,17 +24,34 @@ fun ProfileResponseDto.toDomain(): UserProfile = UserProfile(
    finishedStudies = finishedStudies.map { it.toDomain() },
 )

+fun ProfileResponseDto.toEntity(): UserProfileEntity = UserProfileEntity(


링랑은 투도메인 투앤티티 파였군

이것도 팀 컨벤션을 맞춰볼까요?

s9hn · 2023-11-21T08:41:55Z

android/app/src/main/java/com/created/team201/data/model/UserProfileEntity.kt

@@ -0,0 +1,8 @@
+package com.created.team201.data.model
+
+import com.created.domain.model.Profile


아쉽게도 데이터가 도메인을 알아버렸읍니다..

s9hn · 2023-11-21T08:49:29Z

android/app/src/main/java/com/created/team201/data/model/FinishedStudyEntity.kt

+package com.created.team201.data.model
+
+data class FinishedStudyEntity(
+    val id: Long,


이 id가 뷰에서 사용되는 일이 있나요?

no1msh

고생하셨습니다 륑륑!

PR 제목 수정부탁드립니다.!

no1msh · 2023-11-22T08:17:22Z

android/app/src/main/java/com/created/team201/presentation/profile/ProfileUiState.kt

+sealed interface ProfileUiState {
+    data class Success(val userProfile: UserProfileEntity) : ProfileUiState
+    object Failure : ProfileUiState
+    object Loading : ProfileUiState
+}


정석적인 사용이군요 👍

no1msh · 2023-11-22T08:41:11Z

...pp/src/main/java/com/created/team201/presentation/profile/adapter/FinishedStudyViewHolder.kt

+    private fun ImageView.setImage(image: Int) {
+        Glide.with(context)
+            .load(image)
+            .into(this)
    }


자주 보이는 함수 인거 같은데 유틸로 빼놔도 좋겠다는 생각이 듭니다!

ImageView.setImage(image: Int)
의 파라미터로 @DrawableRes어노테이션 추가해줘도 좋을듯 합니다!

no1msh · 2023-11-22T08:44:27Z

android/app/src/main/java/com/created/team201/presentation/profile/ProfileActivity.kt

+    private fun updateProfile(userProfile: UserProfileEntity) {
+        binding.ivProfileImage.setImage(userProfile.profile.profileImageUrl)
+        binding.tvProfileUserName.text = userProfile.profile.profileInformation.nickname.nickname
+        binding.tvProfileUserGithubId.text = userProfile.profile.githubId
+        binding.layoutProfileStudySuccessRate.result =
+            getString(R.string.profile_success_rate_format).format(userProfile.profile.successRate)
+        binding.layoutProfileTodoSuccessRate.result =
+            getString(R.string.profile_mustdo_success_rate_format).format(userProfile.profile.successfulRoundCount)
+        binding.tvProfileUserDescription.text = userProfile.profile.profileInformation.introduction
+        finishedStudyAdapter.submitList(userProfile.finishedStudies)
+        binding.layoutProfileTodoSuccessRate.isVisible = true
+        binding.layoutProfileStudySuccessRate.isVisible = true
+    }


오... 뷰바로 빼니.. 생각보다 엄청나게 액티비티가 뚱뚱해지는군요 ㅠㅠ

no1msh · 2023-11-22T08:45:35Z

android/app/src/main/java/com/created/team201/data/mapper/UserProfileMapper.kt

@@ -24,17 +24,34 @@ fun ProfileResponseDto.toDomain(): UserProfile = UserProfile(
    finishedStudies = finishedStudies.map { it.toDomain() },
 )

+fun ProfileResponseDto.toEntity(): UserProfileEntity = UserProfileEntity(


이것도 팀 컨벤션을 맞춰볼까요?

RightHennessy added 8 commits November 21, 2023 13:05

refactor: 기존 BindingActivity -> BindingViewActivity

baa47cf

fix: 종료한 스터디 정상적으로 보이게 수정

5f18e59

refactor: UiModel 제거

f674460

- FinishedStudyUiModel - UserProfileUiModel

refactor: 종료된 스터디 리스트 databinding -> viewbinding으로 변경

6bfca67

style: 함수 분리

afac09a

refactor: domain 모델 대신 data Entity 사용하도록 변경

cbf09cf

refactor: uiState, Flow 적용

3845790

refactor: 사용자를 찾을 수 없는 경우 뷰 처리

543ebf0

RightHennessy added android💚 안드 refactor 리팩터링 ringring🤙 링링 labels Nov 21, 2023

RightHennessy requested review from no1msh and s9hn November 21, 2023 08:02

RightHennessy self-assigned this Nov 21, 2023

s9hn requested changes Nov 21, 2023

View reviewed changes

no1msh approved these changes Nov 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

An/feature/615 profile #616

An/feature/615 profile #616

RightHennessy commented Nov 21, 2023

github-actions bot commented Nov 21, 2023

s9hn left a comment

s9hn Nov 21, 2023

no1msh Nov 22, 2023

s9hn Nov 21, 2023

s9hn Nov 21, 2023

no1msh left a comment

no1msh Nov 22, 2023

no1msh Nov 22, 2023

no1msh Nov 22, 2023

no1msh Nov 22, 2023

		@@ -0,0 +1,8 @@
		package com.created.team201.data.model

		import com.created.domain.model.Profile

An/feature/615 profile #616

Are you sure you want to change the base?

An/feature/615 profile #616

Conversation

RightHennessy commented Nov 21, 2023

😋 작업한 내용

🙏 PR Point

👍 관련 이슈

github-actions bot commented Nov 21, 2023

Test Results

s9hn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

no1msh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment