-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[스레드뷰] 서버 연결 및 부가 기능 추가 #515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
지금은 Spinner method로 강제로 닫고 있는데, 이를 더 개선할 수 있으면 좋을 것 같습니다. 아니면 Spinner CustomView를 만들어서 현재 부르는 메소드를 오버라이드 하는 방법도 있다는데 일단 CustomView를 만드는건 제외했습니다.
이거 더 예쁘게 해보고 싶었는데.. uistate update 하는 일반적인 로직을 몰라서 일단은 비교해서 업데이트하도록 변경하였습니다. (기존에 있던 copy 동작 x)
1. adapter에 registerAdapterDataObserver를 붙이는 방법 2. submitList와 scrollToPosition 사이에 delay 주는 법 위 두가지 방법이 있는데 위에걸 선택했습니다아 ~
release에 있는 기능인데 저번에 develop에 안넣어서 지금 그냥 추가합니다 ~
…igongil into AN/feature/441-studythread-remote
inseonyun
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
no1msh
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
군산과 바통터치한 링그링그 다 고생했습니다!
신프로브.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
이 브랜치 기능 붙이는게 너무 커져서 먼저 머지하고 작업 이어가려고 합니다!
산군이 해놓은 작업을 제가 이어서 작업해서 리뷰요청을 써니와 반달에게 드립니다.
기존의 uistate에 변경점이 생겨서 산군이 바꾸고 싶은 점 있으면 바꾸셔도 됩니다. 아니면 나한테 바꿔달라고 하세염 ㅇ_ㅇ
(산군에게 많은 질문 부탁드립니다)
링링
👍 관련 이슈
기획의 어떤 부분을 구현 / 수정했는가 (굉장히 상세하게 적어주세요, 해당 커밋의 링크, 코드의 위치를 남겨주면 더욱 좋습니다.)
산군 여기에.. 쓰고 싶은 말 좀 써줘...
@s9hn