Feat/#25 Log를 저장할 떄 appKey를 검증하도록 수정

[miiiinju1]

🚀 작업 내용

• appKey가 존재하는 지 확인하는 쿼리 메서드 추가
• Log를 저장할 때 appKey가 존재하는지 확인하도록 수정했습니다.

📸 이슈 번호

• close [💡 FEAT] log를 저장할 때 appKey에 관한 유효성 검사를 추가한다. #25

👀 Focus Commits [Optional]

• 커밋해시: 내용

✍ 궁금한 점

• 중점적으로 봐줄 내용
• 변수명 괜찮나요
• 로직이 좀 더럽나요
• 가독성이 좀 그런가요?

[github-actions]

Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat/src/main/java/info/logbat/domain/project/repository/AppJpaRepository.java

1. The removal of the findByToken method may impact existing functionality if it is still being used elsewhere in the codebase. Ensure that this method is not referenced before removing it.

---

Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat/src/test/java/info/logbat/domain/log/application/LogServiceTest.java

1. The test method names are in Korean, which may reduce readability for non-Korean speakers. Consider using English for consistency and wider accessibility. Example:

   @DisplayName(\"Cannot save log with non-existent Application Key\")
   void saveLogWithNonExistentAppKey() {
       // test implementation
   }

---

Risk Level 3 - /home/runner/work/Team5-Guys/Team5-Guys/logbat/src/main/java/info/logbat/domain/log/application/LogService.java

1. The method getAppKey throws a generic IllegalArgumentException. Consider creating a custom exception for better clarity and handling. Example:

   public class InvalidAppKeyException extends RuntimeException {
       public InvalidAppKeyException(String message) {
           super(message);
       }
   }

2. The method getAppKey could benefit from clearer naming. Consider renaming it to validateAndGetAppKey to reflect its purpose more accurately.

---

🔍⚠️📜

---

Powered by Code Review GPT

[tidavid1]

👍🏻

[tidavid1]

이 부분도 getAppKey() 부분에 들어가 있으면 어떨까요?

[miiiinju1]

좋아요~~

[tidavid1]

린트 크아ㅏㅏㅏㄱ

[LuizyHub]

잘 봤습니다!