Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#82 LogData 필드 변경 #83

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Refactor/#82 LogData 필드 변경 #83

merged 1 commit into from
Aug 19, 2024

Conversation

tidavid1
Copy link
Member

🚀 작업 내용

  • LogData 필드 변경을 진행했습니다.
    • level: String -> Integer.

📸 이슈 번호

- level: String to Integer
- 이에 따른 메서드 및 테스트 수정을 진행했습니다.
@tidavid1 tidavid1 self-assigned this Aug 19, 2024
@tidavid1 tidavid1 added the 🔄 Refactor 코드 리팩토링 label Aug 19, 2024
Copy link

Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_view/src/main/java/info/logbat_view/domain/log/domain/LogData.java

The addition of private final Integer level; could lead to confusion if the level is not validated. Ensure that the level is within the expected range of values to prevent runtime errors.


Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_view/src/main/java/info/logbat_view/domain/log/domain/Log.java

The addition of LogLevel.from(logData.getLevel()) assumes that the level in LogData is always valid. If an invalid level is passed, it could lead to an exception. Consider adding validation or handling for unexpected values.


🔍⚠️


Powered by Code Review GPT

Copy link
Member

@LuizyHub LuizyHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다!

Copy link
Member

@miiiinju1 miiiinju1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~~

@tidavid1 tidavid1 merged commit a1fa5c1 into dev Aug 19, 2024
1 check passed
@tidavid1 tidavid1 deleted the refactor/#82 branch August 19, 2024 05:10
LuizyHub pushed a commit that referenced this pull request Aug 19, 2024
- level: String to Integer
- 이에 따른 메서드 및 테스트 수정을 진행했습니다.
@tidavid1 tidavid1 linked an issue Aug 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🛠 REFACT] View Server - Log 필드 타입 변경
3 participants