Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#66 JS SDK api 명세에 맞게 수정 #70

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Feat/#66 JS SDK api 명세에 맞게 수정 #70

merged 3 commits into from
Aug 17, 2024

Conversation

LuizyHub
Copy link
Member

🚀 작업 내용

  • fix: app-ip -> appKey in SDK
  • fix: created_at -> timestamp
  • fix: Nginx CORS 허용 헤더 변경
    • app-id -> appKey

📸 이슈 번호

✍ 궁금한 점

@LuizyHub LuizyHub requested a review from a team August 16, 2024 01:56
@LuizyHub LuizyHub self-assigned this Aug 16, 2024
Copy link

Risk Level 3 - /home/runner/work/Team5-Guys/Team5-Guys/sdk/js/src/tests/index.test.ts

The use of hardcoded values for 'appKey' and the API endpoint poses a risk if these values are sensitive. Consider using environment variables or a secure configuration management system to handle such values. Additionally, ensure that the test cases are not relying on these hardcoded values in production code.


Risk Level 3 - /home/runner/work/Team5-Guys/Team5-Guys/sdk/js/src/index.ts

The static method 'init' directly assigns the appKey from the config object without validation. Consider adding validation to ensure that the appKey is not empty or malformed before assignment. This will help prevent potential issues during runtime. Example:

if (!config.appKey) {
    throw new Error('appKey is required');
}

🔒⚠️


Powered by Code Review GPT

Copy link
Member

@tidavid1 tidavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@miiiinju1 miiiinju1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tidavid1 tidavid1 merged commit ff1965a into dev Aug 17, 2024
1 check passed
@tidavid1 tidavid1 deleted the feat/#66 branch August 17, 2024 06:25
LuizyHub added a commit that referenced this pull request Aug 19, 2024
* fix: app-ip -> appKey in SDK

* fix: created_at -> timestamp

* fix: Nginx CORS 허용 헤더 변경

- app-id -> appKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants