-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#19 App Key 생성 및 서비스 구현 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- App 생성시 UUID 기반 토큰이 생성되도록 했습니다. - 이에 따른 테스트를 수정했습니다.
- App 생성을 진행하고 DB 저장후 결과를 반환하는 서비스 로직을 구현했습니다. - 요청에 대한 반환은 `AppCommonResponse` DTO를 통해 반환됩니다.
- Token을 활용해 App을 조회하는 로직을 구현했습니다. - ID를 활용해 App을 조회하는 로직을 구현했습니다. - 이에 따른 테스트를 추가했습니다.
- 토큰 기반 조회 쿼리 성능 향상을 위해 인덱싱을 명시했습니다.
- App 삭제를 진행하고 성공시 삭제한 App Id를 반환하도록 했습니다.
- App 서비스 메서드들에 대해 `@Transactional`을 적용했습니다.
logbat/src/main/java/info/logbat/domain/project/application/AppService.java
Show resolved
Hide resolved
...rc/main/java/info/logbat/domain/project/presentation/payload/response/AppCommonResponse.java
Show resolved
Hide resolved
logbat/src/main/java/info/logbat/domain/project/repository/AppJpaRepository.java
Show resolved
Hide resolved
logbat/src/test/java/info/logbat/domain/project/application/AppServiceTest.java
Show resolved
Hide resolved
This was
linked to
issues
Aug 13, 2024
Closed
Closed
LuizyHub
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UUID로 토큰 발급하는거 잘 확인했습니다!
miiiinju1
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
miiiinju1
pushed a commit
that referenced
this pull request
Aug 13, 2024
* feat: App token 추가 - App 생성시 UUID 기반 토큰이 생성되도록 했습니다. - 이에 따른 테스트를 수정했습니다. * feat: App 생성 로직 구현 - 서비스 - App 생성을 진행하고 DB 저장후 결과를 반환하는 서비스 로직을 구현했습니다. - 요청에 대한 반환은 `AppCommonResponse` DTO를 통해 반환됩니다. * feat: App 조회 로직 구현 - 서비스 - Token을 활용해 App을 조회하는 로직을 구현했습니다. - ID를 활용해 App을 조회하는 로직을 구현했습니다. - 이에 따른 테스트를 추가했습니다. * chore: 인덱싱 추가 - 토큰 기반 조회 쿼리 성능 향상을 위해 인덱싱을 명시했습니다. * feat: App 삭제 로직 구현 - 서비스 - App 삭제를 진행하고 성공시 삭제한 App Id를 반환하도록 했습니다. * feat: App 서비스 트랜젝션 추가 - App 서비스 메서드들에 대해 `@Transactional`을 적용했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개발 사항
AppCommonResponse
DTO를 통한 결과 반환이슈 번호
특이 사항 🫶