Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#31 Log를 저장하는 API 구현 #34
Feat/#31 Log를 저장하는 API 구현 #34
Changes from all commits
9a6ab00
f1c98c7
fd87d0d
05ecdbd
354d1ac
52c2472
50a8379
10c1c28
0d8aa8b
aee7b31
1d5d4be
f22d813
559ae43
df4d92e
d340c0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어플리케이션 ID를 어떤 형식으로 해야할지 더 논의해보면 좋겠어요!
난수 String이 더 안전하지 않을까 생각이 듭니다 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WebMVCTest
vs@SpringBootTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service 레이어는 DB붙여서 테스트하는 것이 더 좋다고 생각해서
@SpringBootTest
를 이용해야 하지 않을까 생각됩니다!!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이부분도 서비스 테스트에서 데이터베이스는 모킹 안되어 있는데 어떤 방식으로 하면 좋을지 더 논의해봐요!
repository layer는 저도 이렇게 주입받아 쓰는면이 유지보수도 용이하고 테스트 컨테이너를 사용할 예정이라 좋아보여요!