Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#118 /favicon.ico에 대한 파일 내려주기 추가 #119

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

LuizyHub
Copy link
Member

🚀 작업 내용

  • nginx에서 favicon.ico를 내려줄 수 있도록 설정
image

📸 이슈 번호

✍ 궁금한 점

  • 중점적으로 봐줄 내용
  • 변수명 괜찮나요
  • 로직이 좀 더럽나요
  • 가독성이 좀 그런가요?

@LuizyHub LuizyHub added the 💇🏻‍♀️ Style 스타일 관련 기능(코드 포맷팅, 세미콜론 누락, 코드 자체의 변경이 없는 경우) label Aug 25, 2024
@LuizyHub LuizyHub requested a review from a team August 25, 2024 14:23
@LuizyHub LuizyHub self-assigned this Aug 25, 2024
@LuizyHub LuizyHub changed the title feat: /favicon.ico에 대한 파일 내려주기 추가 Feat/#118 /favicon.ico에 대한 파일 내려주기 추가 Aug 25, 2024
Copy link
Member

@tidavid1 tidavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 디테일 너무 좋습니다 👍🏻

Copy link
Member

@miiiinju1 miiiinju1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@miiiinju1 miiiinju1 merged commit 062f29b into dev Aug 26, 2024
1 check passed
@miiiinju1 miiiinju1 deleted the feat/#118 branch August 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💇🏻‍♀️ Style 스타일 관련 기능(코드 포맷팅, 세미콜론 누락, 코드 자체의 변경이 없는 경우)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants