Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat#152/ 전역 에러 핸들러, 티켓 구매 관련 api 연결 #154

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat#152/ 전역 에러 핸들러, 티켓 구매 관련 api 연결 #154

merged 5 commits into from
Aug 28, 2024

Conversation

kkyu0718
Copy link
Collaborator

📄 작업 설명

502 에러를 로드밸러서에서 준 경우 자동으로 cdn 으로 갈 수 있도록 전역 에러핸들러를 추가했어요. -> 현재 임시로 네이버로 리다이렉트되도록 해놨어요. 내일 정상작동 확인 필요합니다.
티켓 구매 관련 api 모두 연결했어요. 지금 api 가 ticketId=1 로 박혀있어서 저도 1번 티켓에 대해 테스트를 했어요. 내일 스크립트 받아서 수백명 동시에 올때 대기번호 제대로 보이는지 확인을 해야돼요.

🚨 관련 이슈

closes #152

🌈 작업 상황

  • 전역에러핸들러 추가 완료
  • 대기열 진입 api 연결
  • 구매 api 연결
  • 구매 상태 확인 api 연결

📌 기타

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for twodari ready!

Name Link
🔨 Latest commit 0d1a868
🔍 Latest deploy log https://app.netlify.com/sites/twodari/deploys/66cf4ce1eaeb1d000837bbf7
😎 Deploy Preview https://deploy-preview-154--twodari.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/queue-server/src/main/java/com/wootecam/festivals/domain/wait/service/WaitOrderService.java

The method getWaitOrder has complex logic that could benefit from additional comments or refactoring for clarity. Ensure that all edge cases are handled.

Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/purchase/service/PurchaseService.java

The method validPurchasableMember should handle potential null values more gracefully. Consider adding null checks to avoid NullPointerExceptions.

Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/payment/service/PaymentService.java

The use of Thread.sleep(500) in processPayment can lead to performance issues and blocking behavior. Consider using a non-blocking approach or a scheduled task instead.

📝🔍⚠️

Powered by Code Review GPT

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Code Coverage Report

Overall Project 88.39% 🍏

There is no coverage information present for the Files changed

bellringstar
bellringstar approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@bellringstar bellringstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

그런데 배포시에 api 요청 url을 /api/v1 으로 해줘야 연결이 가능합니다! 앞의 http://localhost:8080 부분을 제거해주세요~

@kkyu0718 kkyu0718 merged commit 65de5bb into develop Aug 28, 2024
7 checks passed
@kkyu0718 kkyu0718 deleted the feat#152 branch August 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellringstar bellringstar bellringstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: FE 전역 에러 핸들러, CDN 페이지 제작
2 participants
@kkyu0718 @bellringstar