Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat#109/ 멀티 모듈 구성 #110

Merged
merged 28 commits into from
Aug 22, 2024
Merged

feat#109/ 멀티 모듈 구성 #110

merged 28 commits into from
Aug 22, 2024

Conversation

kkyu0718
Copy link
Collaborator

📄 작업 설명

멀티모듈 구성 완료하였습니다.

🚨 관련 이슈

closes #109

🌈 작업 상황

  • api-server, queue-server 분리하였으며 build.gradle 은 각각 관리하도록 하였습니다.

📌 기타

@kkyu0718 kkyu0718 self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/purchase/service/PurchaseService.java

Ensure that the purchase logic handles edge cases, such as concurrent purchases.


Risk Level 3 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/domain/checkin/service/CheckinService.java

The comment regarding the check-in process should be updated to reflect the current implementation.


Risk Level 5 - /home/runner/work/Team2-Dari/Team2-Dari/backend/api-server/src/main/java/com/wootecam/festivals/global/config/CloudConfiguration.java

API keys and secrets are present in plain text. Consider using environment variables or a secure vault.


🔍⚠️🔒


Powered by Code Review GPT

Copy link

github-actions bot commented Aug 21, 2024

Code Coverage Report - api-server

File Coverage [93.3%] 🍏
FestivalParticipantService.java 100% 🍏
FestivalService.java 100% 🍏
FestivalSchedulerService.java 100% 🍏
MemberController.java 100% 🍏
TicketValidator.java 100% 🍏
CustomLocalDateTimeSerializer.java 100% 🍏
FestivalController.java 100% 🍏
FestivalParticipantController.java 100% 🍏
Ticket.java 100% 🍏
TicketStock.java 100% 🍏
AuthService.java 100% 🍏
AuthController.java 100% 🍏
FileService.java 100% 🍏
AuthInterceptor.java 100% 🍏
CheckinController.java 100% 🍏
MyController.java 100% 🍏
CheckinService.java 100% 🍏
CursorBasedPage.java 100% 🍏
PurchaseFacadeService.java 100% 🍏
TicketStockRollbacker.java 100% 🍏
Member.java 100% 🍏
MemberService.java 100% 🍏
Purchase.java 100% 🍏
FileController.java 100% 🍏
SessionConfig.java 100% 🍏
Authentication.java 100% 🍏
MyService.java 100% 🍏
TicketController.java 100% 🍏
TicketService.java 100% 🍏
PurchaseAuthorityCleanupScheduleService.java 99.02% 🍏
FestivalValidator.java 97.54% 🍏
PurchaseController.java 97.27% 🍏
PaymentService.java 91.3% 🍏
FilePrefixType.java 90.32% 🍏
PurchaseService.java 89.56% 🍏
Festival.java 88.06% 🍏
SessionUtils.java 87.88% 🍏
FestivalProgressStatus.java 84.21% 🍏
FestivalStatusUpdateService.java 82.35% 🍏
FestivalPublicationStatus.java 80.65% 🍏
CheckinErrorCode.java 80% 🍏
PurchaseErrorCode.java 80% 🍏
Checkin.java 80% 🍏
FestivalErrorCode.java 80% 🍏
TicketErrorCode.java 80% 🍏
AuthErrorCode.java 80% 🍏
MemberErrorCode.java 76.09%
DateTimeUtils.java 66.67%
TimeProvider.java 60%
AuthenticationUtils.java 59.09%
PurchaseStatus.java 55.56%
UuidProvider.java 50%
AuthArgumentResolver.java 0%
Total Project Coverage 93.3% 🍏

jacoco, rest-docs 등 공통적인 것은 root 에서 관리하고 모듈별로 의존성 따로 관리하도록 분리
jacoco 리포트 생성 위해 추가
두개의 Job 으로 각각 요청하면 토큰 유효성 에러가 나기 때문에 한번에 올리도록 수정
Copy link

github-actions bot commented Aug 21, 2024

Code Coverage Report

Overall Project 93.84% 🍏
Files changed 100% 🍏

Module Coverage
queue-server 100% 🍏
api-server 93.83% 🍏
Files
Module File Coverage
queue-server SimpleTest.java 100% 🍏
api-server FestivalParticipantService.java 100% 🍏
FestivalService.java 100% 🍏
FestivalSchedulerService.java 100% 🍏
MemberController.java 100% 🍏
TicketValidator.java 100% 🍏
AuthenticationUtils.java 100% 🍏
CustomLocalDateTimeSerializer.java 100% 🍏
FestivalController.java 100% 🍏
FestivalParticipantController.java 100% 🍏
Ticket.java 100% 🍏
TicketStock.java 100% 🍏
AuthService.java 100% 🍏
AuthController.java 100% 🍏
FileService.java 100% 🍏
AuthInterceptor.java 100% 🍏
CheckinController.java 100% 🍏
MyController.java 100% 🍏
CheckinService.java 100% 🍏
CursorBasedPage.java 100% 🍏
PurchaseFacadeService.java 100% 🍏
TicketStockRollbacker.java 100% 🍏
Member.java 100% 🍏
MemberService.java 100% 🍏
Purchase.java 100% 🍏
FileController.java 100% 🍏
SessionConfig.java 100% 🍏
Authentication.java 100% 🍏
MyService.java 100% 🍏
TicketController.java 100% 🍏
TicketService.java 100% 🍏
PurchaseAuthorityCleanupScheduleService.java 99.02% 🍏
FestivalValidator.java 97.54% 🍏
PurchaseController.java 97.28% 🍏
PaymentService.java 91.3% 🍏
FilePrefixType.java 90.32% 🍏
PurchaseService.java 89.56% 🍏
Festival.java 88.06% 🍏
SessionUtils.java 87.5% 🍏
FestivalProgressStatus.java 84.21% 🍏
AuthErrorCode.java 82.81% 🍏
FestivalStatusUpdateService.java 82.35% 🍏
FestivalPublicationStatus.java 80.65% 🍏
CheckinErrorCode.java 80% 🍏
PurchaseErrorCode.java 80% 🍏
Checkin.java 80% 🍏
FestivalErrorCode.java 80% 🍏
TicketErrorCode.java 80% 🍏
MemberErrorCode.java 76.09% 🍏
DateTimeUtils.java 66.67% 🍏
TimeProvider.java 60% 🍏
PurchaseStatus.java 55.56% 🍏
UuidProvider.java 50% 🍏
AuthArgumentResolver.java 0% 🍏

Copy link
Member

@HyeonJun0530 HyeonJun0530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !

@minnim1010 minnim1010 merged commit 84b4d84 into develop Aug 22, 2024
3 checks passed
@minnim1010 minnim1010 deleted the feat#109 branch August 22, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 멀티 모듈 구성
3 participants