Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Creation AI] Remove feature flag and unused code #14010

Merged
merged 23 commits into from
Oct 2, 2024

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Sep 20, 2024

Closes: #13118
Closes: #13103
Closes: #13266

Description

Removes product creation AI feature flags. Removes unused code related to product creation AI feature.

🗒️ The 300+ line code changes are due to deleted files. I hope it is fine to keep this in a single PR. Let me know if you prefer this to be split into smaller PRs.

Changes

  • Deleted old package flow related code.
  • Remove unused code files tracked by this issue. Remove the package flow and related code. #13266
  • Removed feature flags.
  • Renamed the productName step into productFeatures and update unit tests.
  • Removed unused unit tests.

Steps to reproduce

Prerequisites

  • Create a JN site with "Jetpack AI" plugin enabled
  • Test this on an iPhone/iPad to be able to use camera

Steps

  • Login into the app
  • Navigate to products tap "+"
  • Please follow the test plan and smoke test to ensure the feature works as before. pe5sF9-2Wo-p2
  • Follow instructions from this [Product Creation AI] Release M3 #13412 and it works.

Testing information

  • I smoke-tested the Product Creation AI feature to ensure it works as before.
  • While testing, I found that product image upload failure is not handled. Logged an issue here.

Screenshots

ProductCreationAI.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added the feature: add/edit products Related to adding or editing products. label Sep 20, 2024
@selanthiraiyan selanthiraiyan added this to the 20.6 milestone Sep 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 20, 2024

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 20, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14010-de4a5f1
Version20.6
Bundle IDcom.automattic.alpha.woocommerce
Commitde4a5f1
App Center BuildWooCommerce - Prototype Builds #11083
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot wpmobilebot modified the milestones: 20.6, 20.7 Sep 27, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.6 has now entered code-freeze, so the milestone of this PR has been updated to 20.7.

@selanthiraiyan selanthiraiyan added the category: tracks Related to analytics, including Tracks Events. label Sep 30, 2024
@selanthiraiyan selanthiraiyan marked this pull request as ready for review September 30, 2024 07:08
@hafizrahman hafizrahman self-assigned this Sep 30, 2024
@hafizrahman
Copy link
Contributor

I found the faeture to still work fine in my smoke tests yesterday. I'll continue checking the code now.

Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I got distracted in a different task. Code looks good and comprehensive to me :shipit:

Forgot to add, I smoke tested product creation AI in:

  • Simulator iPad with iOS 17.5
  • iPhone 12 with iOS 17.4.1

Seeing no issue in both of them and the texts were generated properly each time and the draft can be generated and published.

I tested the photo mode using my iPhone and it was still able to find the text in the picture properly.

@selanthiraiyan selanthiraiyan merged commit 23df08d into trunk Oct 2, 2024
14 checks passed
@selanthiraiyan selanthiraiyan deleted the feat/13266-remove-unused-code branch October 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: add/edit products Related to adding or editing products.
Projects
None yet
4 participants