Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7bit support for EML parsing #270

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

wneessen
Copy link
Owner

@wneessen wneessen commented Aug 1, 2024

This PR enhances the EML parsing to handle 7bit (and partly 8bit) content transfer encodings - especially in multi-part messages. Updated related test cases to verify the correct handling of these encodings. This ensures compliance with RFC2045.

This PR closes #262

Implemented a new encoding type, `EncodingUSASCII`, representing US-ASCII (7bit) encoding. Updated the test suite to include this new encoding in the test cases, ensuring proper validation and coverage.
Enhanced EML parsing to handle 7bit and 8bit content transfer encodings. Updated related test cases to verify the correct handling of these encodings. This ensures compliance with RFC2045 for defaulting to 7bit when no encoding is specified.
@wneessen wneessen linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (b4acaf1) to head (ed93e51).

Files Patch % Lines
eml.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   85.22%   85.41%   +0.18%     
==========================================
  Files          25       25              
  Lines        2058     2070      +12     
==========================================
+ Hits         1754     1768      +14     
+ Misses        178      177       -1     
+ Partials      126      125       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen wneessen merged commit 3ca2968 into main Aug 1, 2024
28 of 29 checks passed
@wneessen wneessen deleted the feature/262_support-7bit-encoding branch August 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why there is no support for emails with Content-Transfer-Encoding: 7bit
1 participant