Full sync on build file changes #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ittaiz
reviewed
Jan 30, 2023
| } | ||
| }); | ||
| return ImmutableSet.copyOf(sourceFiles); | ||
| } | ||
|
|
||
| private static void addBuildFile(Set<File> sourceFiles, String workSpaceRootPath, | ||
| String buildFilePath) { | ||
| File buildFile = new File(workSpaceRootPath, buildFilePath); |
There was a problem hiding this comment.
Honest question, why would that be better? Or I don't understand what you mean
There was a problem hiding this comment.
Because Path is the more idiomatic tool when writing Java code.
Part of the challenge in Java is that you have all of the old APIs forever so the motivation to move to the newer better abstractions is low.
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
5215b08
to
380a8e9
Compare
…47) * only filters labels according to parent packages for LanguageClass.C This is to keep supporting CPP need while also supporting aggregate targets More info: https://bazelbuild.slack.com/archives/CM8JQCANN/p1566481600003600 Filter was deliberately added to fix an issue with C++ headers. The original bug was that opening the BUILD file for foo/bar.h caused it to open baz/qux/BUILD because there’s a cc_library target in baz/qux that includes foo/bar.h in its headers. The source-to-target look up queries the index for the target during the last sync which compiled the source file. In this case, it was the cc_library target in baz/qux. So the fix was to ensure that the BUILD file is always for the parent package (foo/bar)
Don't use ijars as they break source navigation - ignore java_import /_ijar/ as its original location is not know - replace -ijar with sibling full jar - replace -hjar with sibling full jar https://youtrack.jetbrains.com/issue/SCL-16975/Navigation-to-attached-Scala-sources-for-interface-jar-does-not-work
Add support for scala source attachment
Add source root detection for Java and Scala source jars. Detection is required when dire4ctory structure in source jar has deeper structure than source packages. Source attachement changes for 2022.3 support
`idea.plugin.protoeditor` needs to be aware of source roots of proto libraries Add proto files to target sources
Via running bloop and BSP Fast test supports ITs Location substitution supports runpath(s) in addition to location(s) Still includes a hack of the env variable of BUILD_TOOL which we need to see how to remove but at least a smaller hack than before Full Compile on proto file changes don't update sources after proto change already exists
WixBuildServer
force-pushed
the
wix-master
branch
from
380a8e9
to
60b5109
Compare
mildagle
force-pushed
the
fast-test-build-file-changes
branch
from
d22d2f2
to
7597c75
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
150a6fd
to
f14b17f
Compare
WixBuildServer
force-pushed
the
wix-master
branch
from
f14b17f
to
b240a62
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
8b5dcf2
to
5e997b6
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
0bfb111
to
0820309
Compare
WixBuildServer
force-pushed
the
wix-master
branch
4 times, most recently
from
63a8008
to
2966d75
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
b06f7c9
to
00c4218
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
760b14f
to
8f7195f
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
d75934d
to
55c12f1
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
c4688fc
to
7d1319b
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
2686c19
to
5b80ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change