Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove already inherited interfaces #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove already inherited interfaces #278

wants to merge 1 commit into from

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented Sep 9, 2022

  • WitnetRequestBoardUpgradableBase is already Proxiable because is inheriting Upgradeableand Upgradeable is Proxiable
  • WitnetRequestBoardTrustableBoba is already Payable becasue is inherinting WitnetRequestBoardTrustableBase and WitnetRequestBoardTrustableBase is Payable

@Tommytrg Tommytrg force-pushed the remove-inherited-interfaces branch 2 times, most recently from 42998af to 7277bec Compare October 26, 2022 09:22
aesedepece
aesedepece reviewed Oct 26, 2022
View reviewed changes
contracts/impls/WitnetRequestBoardUpgradableBase.sol
@@ -17,7 +17,6 @@ import "./WitnetProxy.sol";
/// @author The Witnet Foundation.
abstract contract WitnetRequestBoardUpgradableBase
is
Proxiable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which of Upgradable or WitnetRequestBoard is Proxiable? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aesedepece aesedepece aesedepece approved these changes

@guidiaz guidiaz Awaiting requested review from guidiaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tommytrg @aesedepece