[PoC] include a delay in block broadcasting to mitigate late blocks #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrubiorod
force-pushed
the
poc_late_blocks
branch
from
5caaec4
to
add3d9a
Compare
lrubiorod
force-pushed
the
poc_late_blocks
branch
from
f244e58
to
260b758
Compare
lrubiorod
changed the title
tmpolaczyk
reviewed
Nov 26, 2021
| @@ -3528,19 +3593,19 @@ mod tests { | |||
| assert_ne!(block_1, block_mal_1); | |||
|
|
|||
| // Process the modified candidate first | |||
| chain_manager.process_candidate(block_mal_1); | |||
| chain_manager.process_candidate(&mut Context::new(), block_mal_1, (0, 0)); | |||
There was a problem hiding this comment.
I didn't know it was possible to call Context::new()... But maybe it's better to send an AddCandidates message? This is inside an async block so we can just call send().await.
aesedepece
force-pushed
the
master
branch
3 times, most recently
from
6b3142a
to
9781266
Compare
aesedepece
force-pushed
the
master
branch
2 times, most recently
from
3e8bb07
to
ed5e532
Compare
aesedepece
force-pushed
the
master
branch
3 times, most recently
from
d28f025
to
5bf0421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2117